Fix bounds check in name_parse function #1846
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a bounds check before memcpy operation in name_parse() function to improve security. This ensures that label_len bytes can be safely read from the packet buffer before copying memory. The fix prevents potential out-of-bounds reads when processing malformed DNS packets.
The fix adds:
if (j + label_len > length) return -1;
References:
Original fix: libevent/libevent@96f64a0
CVE-2016-10195: https://nvd.nist.gov/vuln/detail/CVE-2016-10195