LibGit2: Try collecting github sideband messages #58914
Draft
+138
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github sends "sideband" messages to
git clone
that would be helpful for Pkg to show.See the
remote:
prefixed messages here.This PR tries to capture and show them as part of our GitError (trying to fix JuliaLang/Pkg.jl#2701), but currently it doesn't detect any messages. I'm not sure why not.
The error below isn't relevant if you have github auth setup, it's only about user/password entry, but I thought maybe we should generally capture things github etc. is telling us.
Note LibGit2 tries 3 times.
(Note
Base.getpass
doesn't currently add a newline after entry likeBase,prompt
does. I think that's a bug which is tentatively fixed here..)