Skip to content

Minor improvements to the recalc explainer #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

captainbrosset
Copy link
Contributor

I made a few improvements to the style recalc explainer. Here is what I did and why:

  1. Moved the feedback section all the way to the top so it's easier to spot.
  2. Moved the cons about the tracing UI into the "existing solution" section. I think it belongs there.
  3. Added \ characters to force line breaks in the rendered HTML (single line breaks in markdown do not create a <br> in html, if you want to a single line break (i.e. not a new paragraph), you need \). And did some other minor md fixes.
  4. Added a red box around the checkbox in the screenshot.

@bwalderman
Copy link
Member

LGTM, I just removed the \'s for single line breaks. I was asked to add line breaks in the raw markdown to make diffing changes easier but these aren't meant to be rendered.

@captainbrosset captainbrosset merged commit 25081d5 into main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants