convert PPT hello world sample to unified manifest #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "id": "runtime_1", | ||
| "type": "general", | ||
| "code": { | ||
| "page": "https://localhost:3000/taskpane.html" |
There was a problem hiding this comment.
I suppose you'll need to update all these "localhost:3000" references...?
There was a problem hiding this comment.
That's not needed. When the user runs npm run build, webpack automatically makes that change in the copy of the manifest that goes into the /dist folder.
Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>
ElizabethSamuel-MSFT
approved these changes
Apr 22, 2025
Rick-Kirkham
added
the
Do Not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Updates the sample to use the unified manifest and remove the XML manifest. As a side effect, it is updated to use webpack and up-to-date scripts in the package.json.
SHOULD NOT BE MERGED UNTIL WXP SUPPORT IN THE UNIFIED MANIFEST IS READY.
Guidance
Updates to use the unified manifest.