[Word] (citation mgmt) Add unified manifest support #967
Conversation
ElizabethSamuel-MSFT
added
the
Do Not Merge
ElizabethSamuel-MSFT
changed the title
| { | ||
| "requirements": { | ||
| "capabilities": [ | ||
| { | ||
| "name": "AddinCommands", | ||
| "minVersion": "1.1" | ||
| } | ||
| ] | ||
| }, | ||
| "id": "runtime_2", | ||
| "type": "general", | ||
| "code": { | ||
| "page": "https://localhost:3000/taskpane.html", | ||
| "script": "https://localhost:3000/taskpane.js" | ||
| }, | ||
| "lifetime": "short", | ||
| "actions": [ | ||
| { | ||
| "id": "ButtonId1_1", | ||
| "type": "openPage", | ||
| "pinnable": false, | ||
| "view": "ButtonId1", | ||
| "multiselect": false, | ||
| "supportsNoItemContext": false | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Something's gone wrong here. The "capabilities" asks for AddinCommands 1.1. But the "actions.type" is "openPage" which is for task panes, not add-in commands. Also, the two URLs in "code" are for a task pane. There's no add-in command in this sample and you've already got a runtime for the task pane, just above this one, so I think this should just be deleted.
There was a problem hiding this comment.
Actually, I thought this was for the ribbon button, so when you click on it, it opens the task pane...
There was a problem hiding this comment.
Actually, I thought this was for the ribbon button, so when you click on it, it opens the task pane...
Based on what I see in the original XML manifest, this add-in has only one button and that is a "Show Task Pane" button. But the JSON manifest has two runtime objects in the "runtimes" array. The first one looks correct to be the runtime for the task pane. But this second one seems to have no purpose, and it's an odd mixture of values that are appropriate for a Show Task Pane button and values that are appropriate for a function command button.
Co-authored-by: Rick Kirkham <Rick-Kirkham@users.noreply.github.com>
ElizabethSamuel-MSFT
changed the title
| - By default, the sample supports the add-in only manifest, which is the **manifest.xml** file in the sample's root directory **Samples/word-citation-management**. For convenience, a copy of the config files specific to this version can be found in the **manifest-configurations/add-in-only** subfolder. | ||
| - To run this version, you can skip to the [Run the sample](#run-the-sample) section. | ||
| - Unified manifest for Microsoft 365 | ||
| - To run the unified manifest for Microsoft 365, which is the **manifest.json** file in the sample's root directory **Samples/word-citation-management**, you need to copy the files from the **manifest-configurations/unified** subfolder to the sample's root directory, replacing the existing config files. |
There was a problem hiding this comment.
Let's have the manifest.json in the manifest-configurations/unified subfolder too instead of the root.
ElizabethSamuel-MSFT
removed
the
Do Not Merge
What's in this Pull Request?
Adds support for the unified manifest for Microsoft 365.