[Word] (citation mgmt) Add unified manifest support #967
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # This file includes environment variables that will be committed to git by default. | ||
|
|
||
| # Built-in environment variables | ||
| TEAMSFX_ENV=dev | ||
| APP_NAME_SUFFIX=dev | ||
|
|
||
| # Updating AZURE_SUBSCRIPTION_ID or AZURE_RESOURCE_GROUP_NAME after provision may also require an update to RESOURCE_SUFFIX, because some services require a globally unique name across subscriptions/resource groups. | ||
| AZURE_SUBSCRIPTION_ID= | ||
| AZURE_RESOURCE_GROUP_NAME= | ||
| RESOURCE_SUFFIX= | ||
|
|
||
| # Generated during provision, you can also add your own variables. | ||
| AZURE_STATIC_WEB_APPS_RESOURCE_ID= | ||
| ADDIN_DOMAIN= | ||
| ADDIN_ENDPOINT= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| @maxLength(20) | ||
| @minLength(4) | ||
| param resourceBaseName string | ||
| param staticWebAppSku string | ||
|
|
||
| param staticWebAppName string = resourceBaseName | ||
|
|
||
| // Azure Static Web Apps that hosts your static web site | ||
| resource swa 'Microsoft.Web/staticSites@2022-09-01' = { | ||
| name: staticWebAppName | ||
| // SWA do not need location setting | ||
| location: 'centralus' | ||
| sku: { | ||
| name: staticWebAppSku | ||
| tier: staticWebAppSku | ||
| } | ||
| properties: {} | ||
| } | ||
|
|
||
|
|
||
| var siteDomain = swa.properties.defaultHostname | ||
|
|
||
| // The output will be persisted in .env.{envName}. Visit https://aka.ms/teamsfx-actions/arm-deploy for more details. | ||
| output AZURE_STATIC_WEB_APPS_RESOURCE_ID string = swa.id | ||
| output ADDIN_DOMAIN string = siteDomain | ||
| output ADDIN_ENDPOINT string = 'https://${siteDomain}' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentParameters.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "parameters": { | ||
| "resourceBaseName": { | ||
| "value": "tab${{RESOURCE_SUFFIX}}" | ||
| }, | ||
| "staticWebAppSku": { | ||
| "value": "Free" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,215 @@ | ||
| { | ||
| "$schema": "https://developer.microsoft.com/json-schemas/teams/vDevPreview/MicrosoftTeams.schema.json", | ||
| "manifestVersion": "devPreview", | ||
| "version": "1.0.1.0", | ||
| "id": "26FEC3DD-D707-4BF5-9AA7-576131C096EC", | ||
| "localizationInfo": { | ||
| "defaultLanguageTag": "en-us" | ||
| }, | ||
| "developer": { | ||
| "name": "Contoso", | ||
| "websiteUrl": "https://www.contoso.com/help", | ||
| "privacyUrl": "https://www.contoso.com/help", | ||
| "termsOfUseUrl": "https://www.contoso.com/help" | ||
| }, | ||
| "name": { | ||
| "short": "Citation manager - sample", | ||
| "full": "Citation manager - sample" | ||
| }, | ||
| "description": { | ||
| "short": "A template to get started with citation management.", | ||
| "full": "A template to get started with citation management." | ||
| }, | ||
| "icons": { | ||
| "outline": "assets/icon-32.png", | ||
| "color": "assets/icon-64.png" | ||
| }, | ||
| "accentColor": "#230201", | ||
| "validDomains": [ | ||
| "https://www.contoso.com", | ||
| "https://localhost:3000" | ||
ElizabethSamuel-MSFT marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ], | ||
| "showLoadingIndicator": false, | ||
| "isFullScreen": false, | ||
| "defaultBlockUntilAdminAction": false, | ||
| "authorization": { | ||
| "permissions": { | ||
| "resourceSpecific": [ | ||
| { | ||
| "name": "Document.ReadWrite.User", | ||
| "type": "Delegated" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "extensions": [ | ||
| { | ||
| "requirements": { | ||
| "scopes": [ | ||
| "document" | ||
| ] | ||
| }, | ||
| "runtimes": [ | ||
| { | ||
| "requirements": { | ||
| "capabilities": [ | ||
| { | ||
| "name": "Taskpane", | ||
| "minVersion": "1.1" | ||
| } | ||
| ], | ||
| "scopes": [ | ||
| "document" | ||
| ], | ||
| "formFactors": [ | ||
| "desktop" | ||
| ] | ||
| }, | ||
| "id": "runtime_1", | ||
ElizabethSamuel-MSFT marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "type": "general", | ||
| "code": { | ||
| "page": "https://localhost:3000/taskpane.html", | ||
| "script": "https://localhost:3000/taskpane.js" | ||
| }, | ||
| "lifetime": "short" | ||
| }, | ||
| { | ||
| "requirements": { | ||
| "capabilities": [ | ||
| { | ||
| "name": "AddinCommands", | ||
| "minVersion": "1.1" | ||
| } | ||
| ] | ||
| }, | ||
| "id": "runtime_2", | ||
| "type": "general", | ||
| "code": { | ||
| "page": "https://localhost:3000/taskpane.html", | ||
| "script": "https://localhost:3000/taskpane.js" | ||
| }, | ||
| "lifetime": "short", | ||
| "actions": [ | ||
| { | ||
| "id": "ButtonId1_1", | ||
| "type": "openPage", | ||
| "pinnable": false, | ||
| "view": "ButtonId1", | ||
| "multiselect": false, | ||
| "supportsNoItemContext": false | ||
| } | ||
| ] | ||
| } | ||
|
There was a problem hiding this comment. Something's gone wrong here. The "capabilities" asks for AddinCommands 1.1. But the "actions.type" is "openPage" which is for task panes, not add-in commands. Also, the two URLs in "code" are for a task pane. There's no add-in command in this sample and you've already got a runtime for the task pane, just above this one, so I think this should just be deleted. There was a problem hiding this comment. Actually, I thought this was for the ribbon button, so when you click on it, it opens the task pane... There was a problem hiding this comment.
Based on what I see in the original XML manifest, this add-in has only one button and that is a "Show Task Pane" button. But the JSON manifest has two runtime objects in the "runtimes" array. The first one looks correct to be the runtime for the task pane. But this second one seems to have no purpose, and it's an odd mixture of values that are appropriate for a Show Task Pane button and values that are appropriate for a function command button. |
||
| ], | ||
| "getStartedMessages": [ | ||
| { | ||
| "requirements": { | ||
| "capabilities": [ | ||
| { | ||
| "name": "Taskpane", | ||
| "minVersion": "1.1" | ||
| } | ||
| ], | ||
| "scopes": [ | ||
| "document" | ||
| ], | ||
| "formFactors": [ | ||
| "desktop" | ||
| ] | ||
| }, | ||
ElizabethSamuel-MSFT marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "title": "Get started with your sample add-in!", | ||
| "description": "Your sample add-in loaded successfully. Go to the HOME tab and click the 'Show Task Pane' button to get started.", | ||
| "learnMoreUrl": "https://go.microsoft.com/fwlink/?LinkId=276812" | ||
| } | ||
| ], | ||
| "ribbons": [ | ||
| { | ||
| "requirements": { | ||
| "capabilities": [ | ||
| { | ||
| "name": "AddinCommands", | ||
| "minVersion": "1.1" | ||
| } | ||
| ], | ||
| "scopes": [ | ||
| "document" | ||
| ], | ||
ElizabethSamuel-MSFT marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "formFactors": [ | ||
| "desktop" | ||
| ] | ||
| }, | ||
| "contexts": [ | ||
| "default" | ||
| ], | ||
| "tabs": [ | ||
| { | ||
| "builtInTabId": "TabHome", | ||
| "groups": [ | ||
| { | ||
| "id": "CommandsGroup", | ||
| "label": "Commands Group", | ||
| "icons": [ | ||
| { | ||
| "size": 16, | ||
| "url": "https://localhost:3000/assets/icon-16.png" | ||
| }, | ||
| { | ||
| "size": 32, | ||
| "url": "https://localhost:3000/assets/icon-32.png" | ||
| }, | ||
| { | ||
| "size": 80, | ||
| "url": "https://localhost:3000/assets/icon-80.png" | ||
| } | ||
| ], | ||
| "controls": [ | ||
| { | ||
| "id": "TaskpaneButton", | ||
| "type": "button", | ||
| "label": "Show Task Pane", | ||
| "icons": [ | ||
| { | ||
| "size": 16, | ||
| "url": "https://localhost:3000/assets/icon-16.png" | ||
| }, | ||
| { | ||
| "size": 32, | ||
| "url": "https://localhost:3000/assets/icon-32.png" | ||
| }, | ||
| { | ||
| "size": 80, | ||
| "url": "https://localhost:3000/assets/icon-80.png" | ||
| } | ||
| ], | ||
| "supertip": { | ||
| "title": "Show Task Pane", | ||
| "description": "Click to show a task pane." | ||
| }, | ||
| "actionId": "ButtonId1_1", | ||
| "overriddenByRibbonApi": false, | ||
| "enabled": true | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "alternates": [ | ||
| { | ||
| "alternateIcons": { | ||
| "icon": { | ||
| "size": 32, | ||
| "url": "https://localhost:3000/assets/icon-32.png" | ||
| }, | ||
| "highResolutionIcon": { | ||
| "size": 64, | ||
| "url": "https://localhost:3000/assets/icon-64.png" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.