Skip to content

Fix Thread.applied_tags for media channels #10178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

owocado
Copy link
Contributor

@owocado owocado commented Apr 30, 2025

Summary

Bikeshedding post: https://discord.com/channels/336642139381301249/1355473537577652234

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz
Copy link
Owner

Rapptz commented Jun 20, 2025

Can we change the formatting of this to not be hard on the eyes? Also generally speaking we don't use pyright specific type ignores in the repo and just use # type: ignore.

@owocado
Copy link
Contributor Author

owocado commented Jun 20, 2025

ok done, lemme know if this is LGTM.

@Rapptz Rapptz merged commit e9f807e into Rapptz:master Jun 20, 2025
8 checks passed
@owocado owocado deleted the account-for-channeltype-media-in-thread-applied-tags branch June 20, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants