Skip to content

Add missing attributes in AppCommandChannel #10180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2025

Conversation

owocado
Copy link
Contributor

@owocado owocado commented Apr 30, 2025

Summary

This PR adds following missing attributes to AppCommandChannel class, the underlying payload for which is partial channel object as mentioned in upstream docs:

  • category_id
  • topic
  • position
  • last_message_id
  • slowmode_delay
  • nsfw (and x.is_nsfw() method)
  • _last_pin
  • _flags attr & flags @​property
  • x.is_news() method for consistency because it exists for TextChannel

Bikeshedding post: https://discord.com/channels/336642139381301249/1355473537577652234

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all missing the .. versionadded:: string.

@owocado owocado requested a review from Rapptz June 20, 2025 19:28
@owocado
Copy link
Contributor Author

owocado commented Jun 20, 2025

ok added

@Rapptz Rapptz merged commit a62b25c into Rapptz:master Jun 20, 2025
8 checks passed
@owocado owocado deleted the add-new-attrs-to-appcommandchannel branch June 21, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants