-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[docs] Work on embeds Guide #7498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docs/guide
Are you sure you want to change the base?
Conversation
docs/guide/topics/embeds.rst
Outdated
|
||
Embeds are a fundamental part of Discord's message format. | ||
|
||
They allow you to embed rich content into your messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably elaborate on what we mean by "rich content".
|
||
The :class:`Embed` class allows usage of the `factory` pattern. | ||
|
||
.. hint:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels kind of silly to directive this as a hint when, without it, this section is only one sentence long.
Next, we need to call :meth:`my_weather_embed.set_thumbnail() <Embed.set_thumbnail>` to set the thumbnail. | ||
To refer to our attachment for the thumbnail, we will use a special URI scheme that Discord provides - ``attachment://``. | ||
|
||
Since we called our file ``thumbnail.png``, we will set the ``url`` parameter to ``attachment://thumbnail.png``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit conflicted on whether we should explain some of the nuances of attachment://
or not.
Filenames get pivoted by Discord before they get attached to this protocol (e.g. my image.png
becomes attachment://my_image.png
) so maybe it's worth touching on it? Might be kind of out of the scope, but I also don't know where else we would bring this up.
I have a page dedicated to [`C++ Tutorials`](https://rapptz.github.io/cpptuts)! | ||
""" | ||
|
||
.. image:: /images/guide/topics/embeds/hyperlink_tooltip_description_embed.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny tooltip! I know this is sort of inevitable since we're doing high quality screenshots, but it might even be worth photoshopping the tooltip to be larger so it looks a little less weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
.. todo | ||
- cover footer | ||
- cover timestamp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move ur ass
In the Discord client, each row of fields can contain a maximum of 3 fields. | ||
|
||
If you wanted to, you could try using the ``inline`` keyword-only argument of :meth:`~Embed.add_field`. | ||
This determines the positioning of the field within the embed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's worth mentioning that inline
actually controls the format of the next field.
If field 0 set's inline
to False
, then field 1 will appear on a new line, and so on.
7413ed6
to
c2fbd98
Compare
Summary
work on embeds guide
Checklist