-
Notifications
You must be signed in to change notification settings - Fork 2k
Properly fetch tags #2200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Properly fetch tags #2200
Conversation
Just saw a lot of PRs for the same: The launched command was always:
2.47.1: no problem
2.48.0: problem
2.48.1: problem
2.49.0: no problem
|
Great investigation, and thanks for going the extra mile to test across multiple Git versions. Confirming from the logs: 2.47.1 and 2.49.0 correctly fetch tags as expected 2.48.0 and 2.48.1 fail to fetch tags even with --tags This validates that the issue is specific to the 2.48.x series and not related to actions/checkout logic directly — but it's great to see this PR work around that inconsistency with a robust fix. |
Closes #1467
Closes #1471
Closes #1662
Closes #1781
Closes #2039
Closes #2041
Closes #2106
Closes #2127
Closes #2199
This fix would allow one to specify
fetch-tags
.Right now, it doesn't work as advertised (ie: no tags were fetched, even when configured as
true
)With this change, it'll add a "--tags" cli entry, which will fetch the tags - regardless of the provided depth.
EDIT: after checking the other tickets and @TingluoHuang 's comment in #2039, I dug deeper and provided an all-encompassing fix for the wrong behaviour in git 2.48.