fix: ensure NumberField validation displays correct errors in React 19 #8491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6684
Since the
change
event (which triggerscommitValidation
) occurs before theblur
event (which triggerscommit
),numberValue
remains in its previous state in the update scheduled bycommitValidation
.As for why this works as expected in React 18 but not in React 19, I suspect it's related to the refactoring of the React Reconciler.
https://stackblitz.com/edit/vitejs-vite-qsexo8nh?file=README.md
✅ Pull Request Checklist:
📝 Test Instructions:
react-spectrum/packages/@react-spectrum/numberfield/test/NumberField.test.js
Line 2399 in a7b1a28
Doesn't look like we can test in React Testing Library.
🧢 Your Project: