Skip to content

fix: ensure NumberField validation displays correct errors in React 19 #8491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chirokas
Copy link
Contributor

@chirokas chirokas commented Jul 4, 2025

Closes #6684

Since the change event (which triggers commitValidation) occurs before the blur event (which triggers commit), numberValue remains in its previous state in the update scheduled by commitValidation.

As for why this works as expected in React 18 but not in React 19, I suspect it's related to the refactoring of the React Reconciler.
https://stackblitz.com/edit/vitejs-vite-qsexo8nh?file=README.md

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

expect(input).not.toHaveAttribute('aria-describedby');

Doesn't look like we can test in React Testing Library.

🧢 Your Project:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAC NumberField validation broken in next.js
1 participant