Skip to content

fix: WaitControllerManagerLog dose not work in test framework #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dspo
Copy link
Contributor

@dspo dspo commented Jul 5, 2025

  • Moved AppendFunc and Filter from internal/utils/k8s.go to pkg/utils/datastructure.go
  • Updated initialSyncDelay variable name in internal/manager/run.go
  • Increased polling timeout for HTTPRoutePolicy status in

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

WaitControllerManagerLog dose not work in test framework because it hard code namespace when get pods.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

- Moved `AppendFunc` and `Filter` from `internal/utils/k8s.go` to `pkg/utils/datastructure.go`
- Updated `initialSyncDelay` variable name in `internal/manager/run.go`
- Increased polling timeout for HTTPRoutePolicy status in
@dspo dspo changed the title fix: the problem that the method WaitControllerManagerLog dose not work fix: WaitControllerManagerLog dose not work in test framework Jul 5, 2025
Copy link
Contributor

@ronething ronething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants