[ISSUE #9504] Optimize log printing #9505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o weihubeats/develop
…o weihubeats/develop
…o weihubeats/develop
…o weihubeats/develop
weihubeats
changed the title
xiaoyifang
reviewed
Jul 4, 2025
| @@ -49,7 +49,7 @@ public Object decode(ChannelHandlerContext ctx, ByteBuf in) throws Exception { | |||
| cmd.setProcessTimer(timer); | |||
| return cmd; | |||
| } catch (Exception e) { | |||
| log.error("decode exception, " + RemotingHelper.parseChannelRemoteAddr(ctx.channel()), e); | |||
| log.error("decode exception, remoteAddress: {}" ,RemotingHelper.parseChannelRemoteAddr(ctx.channel()), e); | |||
There was a problem hiding this comment.
IMO， log.error(String,object,object) ,the third exception will be treated as object which is not intended .
There was a problem hiding this comment.
I don't understand what you mean. I used {} to replace the first parameter, and the second parameter will be printed out as an exception stack normally.
example
ERROR RocketmqRemoting - decode exception, remoteAddress: 192.168.1.1
java.lang.ArithmeticException: / by zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9504