Initial DLSS implementation #19864

JMS55 · 2025-06-29T18:43:47Z

Objective

Closes NVIDIA DLSS (Deep Learning Super Sampling) #8420

Solution

Initial implementation of DLSS upscaling, via https://github.com/bevyengine/dlss_wgpu.
Future PRs will work more on transparency, exposure, working with custom viewports, fixing inevitable resolution override bugs, etc.
DLSS framegen is not planned, but ray-reconstruction is for solari.
FSR3/4, XeSS2, and MetalFX temporal upscaling should be easy to add now if a future contributor wants to. In the future we could have an auto-temporal AA component that handles DLSS/FSR/XeSS/MetalFX/TAA fallbacks automatically.

Testing

Did you test these changes? If so, how?
- Run the anti_aliasing example
Are there any parts that need more testing?
- Different types of scene content and rendering effects to make sure they work with DLSS/upscaling
- Reviewing dlss_wgpu code

Showcase

github-actions · 2025-06-29T18:44:26Z

It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.

Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.

JMS55 · 2025-06-29T18:56:19Z

@cart not sure what licensing concerns there are with this. See the license notes in https://github.com/JMS55/dlss_wgpu/blob/main/README.md.

github-actions · 2025-06-29T19:02:53Z

You added a new example but didn't add metadata for it. Please update the root Cargo.toml file.

JMS55 · 2025-06-29T19:05:58Z

You added a new example but didn't add metadata for it. Please update the root Cargo.toml file.

Lies D:

github-actions · 2025-06-29T19:32:27Z

You added a new example but didn't add metadata for it. Please update the root Cargo.toml file.

cart · 2025-07-01T20:32:03Z

Rad! My only concern here is that we're taking a dependency on an external crate that depends on a specific version of wgpu. This will make upstream bevy wgpu updates harder, as it will require collaboration with owner of the crate (in this case, you, which is much better than a stranger, but still a risk).

@cart not sure what licensing concerns there are with this. See the license notes in https://github.com/JMS55/dlss_wgpu/blob/main/README.md.

I think this is ok, given that the onus is on developers to wire up the SDK themselves.

JMS55 · 2025-07-01T22:03:50Z

Theoretically it's an optional feature, so it shouldn't block wgpu upgrades. Of course I'm happy to update it asap.

I'm also happy to put it in the bevy repo, up to maintainers. I don't have a preference either way.

github-actions · 2025-07-06T19:37:47Z

You added a new example but didn't add metadata for it. Please update the root Cargo.toml file.

crates/bevy_anti_aliasing/src/dlss/mod.rs

alice-i-cecile · 2025-07-09T18:35:39Z

crates/bevy_anti_aliasing/src/dlss/mod.rs

+//! NVIDIA Deep Learning Super Sampling.
+//!
+//! See https://github.com/bevyengine/dlss_wgpu for licensing requirements and setup instructions.
+//!


I would like information on "what happens if your user doesn't have a compatible graphics card here-ish.

Uhh probably an error. Don't insert the component if you haven't checked DlssSupported :P

release-content/release-notes/dlss.md

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>

crates/bevy_anti_aliasing/src/dlss/mod.rs

…ck MainPassResolutionOverride

tychedelia · 2025-06-29T18:53:01Z

crates/bevy_render/src/lib.rs

+
+#[cfg(feature = "dlss")]
+#[derive(Resource)]
+pub struct DlssProjectId(pub bevy_asset::uuid::Uuid);


Does this need to be unique for each application instance? Stable?

Unique per app. The DLSS programming guide provides more details

tychedelia · 2025-07-11T17:18:06Z

crates/bevy_anti_aliasing/src/dlss/mod.rs

+            return;
+        }
+
+        let dlss_project_id = app.world().resource::<DlssProjectId>().0;


Might be nice to have a better error message here if the user forgets to add this.

There already is, it's in bevy render :)

tychedelia · 2025-07-11T17:19:58Z

crates/bevy_anti_aliasing/src/dlss/prepare.rs

+    render_device: Res<RenderDevice>,
+    render_queue: Res<RenderQueue>,
+    frame_count: Res<FrameCount>,
+    mut commands: Commands,


nit: commands first

tychedelia · 2025-07-11T17:24:26Z

crates/bevy_render/src/renderer/mod.rs

I don't have an obvious suggestion for another solution but I really don't like polluting this file with a bunch of dlss feature flags and specific code. It feels like we need a more generalized pattern for modifying the render initialization.

DLSS is special because we need native extensions that you can't enable via wgpu features. This won't be a problem for anything else.

I mean, it's been a problem on some of my own projects, and while that's not going to be upstreamed, I still think having more robust pattern here would be beneficial as the DLSS feature spam adds a lot of noise for a specific rendering feature.

Initial DLSS implementation

c75b2b4

JMS55 added the A-Rendering Drawing game state to the screen label Jun 29, 2025

github-project-automation bot added this to Rendering Jun 29, 2025

JMS55 added C-Feature A new feature, making something new possible M-Needs-Release-Note Work that should be called out in the blog due to impact M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered labels Jun 29, 2025

JMS55 added this to the 0.17 milestone Jun 29, 2025

Update example description

af1b47c

Rename variable

eb8c77f

alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Contentious There are nontrivial implications that should be thought through labels Jun 30, 2025

Merge commit '1579256709dd64dcc4910b0bad5e81622d9ede0c' into dlss3

951c3f9

JMS55 added 6 commits July 6, 2025 17:15

Fix merge

742ebfa

Switch to git dep

463c66d

Merge branch 'main' into dlss3

950f3e8

Add release notes

bf56980

Modify release notes

6b960b0

Add note about DlssSupported

cf1a1f7

janhohenheim mentioned this pull request Jul 8, 2025

Move renderer initialization from build time to RenderStartup #20021

Open

JMS55 added 3 commits July 7, 2025 21:40

Merge commit '5e3927ba489f597dd189f63286dc7985840db1b5' into dlss3

1b71463

Fix resolution override to work even if the camera lacks a viewport

10c96e8

Update release notes

04f488b

JMS55 added 7 commits July 8, 2025 11:53

Docs

e2a9761

Fix typo

fda09d1

Fix

ab113c8

Add missing import

5ab0093

Switch link to https://github.com/bevyengine/dlss_wgpu

baa2668

Fix another link

e2d8a9e

Merge branch 'main' into dlss3

8084745

alice-i-cecile reviewed Jul 9, 2025

View reviewed changes

crates/bevy_anti_aliasing/src/dlss/mod.rs Outdated Show resolved Hide resolved

alice-i-cecile reviewed Jul 9, 2025

View reviewed changes

release-content/release-notes/dlss.md Outdated Show resolved Hide resolved

JMS55 and others added 3 commits July 9, 2025 11:42

Update release-content/release-notes/dlss.md

e202226

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>

Add blurb

1701bb1

Merge branch 'main' into dlss3

6f9114b

JMS55 commented Jul 11, 2025

View reviewed changes

crates/bevy_anti_aliasing/src/dlss/mod.rs Outdated Show resolved Hide resolved

JMS55 added 4 commits July 11, 2025 11:30

Move DLSS setup to ManageViews, so that prepare systems can later che…

484310d

…ck MainPassResolutionOverride

Merge commit '20dfae9a2d07038bda2921f82af50ded6151c3de' into dlss3

27f40ef

Release notes

d962a37

Have Solari account for MainPassResolutionOverride

baa46ae

tychedelia approved these changes Jul 11, 2025

View reviewed changes

Uh oh!

Initial DLSS implementation #19864

Are you sure you want to change the base?

Initial DLSS implementation #19864

Conversation

JMS55 commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Solution

Testing

Showcase

Uh oh!

github-actions bot commented Jun 29, 2025

Uh oh!

JMS55 commented Jun 29, 2025

Uh oh!

github-actions bot commented Jun 29, 2025

Uh oh!

JMS55 commented Jun 29, 2025

Uh oh!

github-actions bot commented Jun 29, 2025

Uh oh!

cart commented Jul 1, 2025

Uh oh!

JMS55 commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 6, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JMS55 commented Jun 29, 2025 •

edited

Loading