Skip to content

Remove Bundle::register_required_components #19967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2025
Merged

Remove Bundle::register_required_components #19967

merged 3 commits into from
Jul 6, 2025

Conversation

SkiFire13
Copy link
Contributor

Objective

  • Bundle::register_required_components is not used anywhere, let's remove it

@BD103 BD103 added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 6, 2025

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

alice-i-cecile
alice-i-cecile reviewed Jul 6, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we have a migration guide. This is a public method on a public trait.

That migration guide can probably be "this was dead code, so we removed it. Please file an issue if you can't figure out a workaround" though.

@SkiFire13 SkiFire13 requested a review from alice-i-cecile July 6, 2025 17:58
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 6, 2025
@alice-i-cecile alice-i-cecile enabled auto-merge July 6, 2025 18:03
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 6, 2025
Merged via the queue into bevyengine:main with commit 8e89511 Jul 6, 2025
34 checks passed
@SkiFire13 SkiFire13 deleted the bundle-remove-required-components branch July 6, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SkiFire13 @alice-i-cecile @BD103