Add validation for recursive type count in loader #4440
Conversation
kylo5aby
requested review from
loganek,
lum1n0us,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
core/iwasm/interpreter/wasm_loader.c
Outdated
| if (rec_count == 0) { | ||
| set_error_buf( | ||
| error_buf, error_buf_size, | ||
| "recursive type count should be greater than 0"); |
There was a problem hiding this comment.
Not sure about that rec_count can't be 0. Would you mind pointing out the relevant content in the GC spec? https://webassembly.github.io/gc/core/valid/modules.html
There was a problem hiding this comment.
Not sure about that
rec_countcan't be 0. Would you mind pointing out the relevant content in the GC spec? https://webassembly.github.io/gc/core/valid/modules.html
I think gc spec doesn't describe it explicitly as mentioned in spec. But in this section, it says that
a rec definition defines a group of mutually recursive types that can refer to each other; it thereby defines several type indices at a time
a single type definition, as in Wasm before this proposal, is reinterpreted as a short-hand for a recursive group containing just one type
that means for a rec, it must has at least 2 types, otherwise, it should be a single type.
for the related implementation in binaryen, only emit rec flag when the number of types greater than 1.
No description provided.