Skip to content

release-25.3: disable create_table_with_schema_locked outside of tests #149487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Jul 3, 2025

Previously, create_table_with_schema_locked was enabled by default in 25.3. Due to recent test failures that need investigation we think its safer to leave this setting disabled outside of tests. This patch disables create_table_with_schema_locked outside of tests.

Release note: None
Informs: #129694
informs #148907
informs #149163

Release justification: low risk change to disable create_table_with_schema_locked outside of tests.

Previously, create_table_with_schema_locked was enabled by default in
25.3. Due to recent test failures that need investigation we think its
safer to leave this setting disabled outside of tests. This patch
disables create_table_with_schema_locked outside of tests.

Release note: None
Copy link

blathers-crl bot commented Jul 3, 2025

Thanks for opening a backport.

Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jul 3, 2025
Copy link

blathers-crl bot commented Jul 3, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@fqazi fqazi marked this pull request as ready for review July 3, 2025 20:19
@fqazi fqazi requested review from a team and rafiss July 3, 2025 20:20
@rafiss rafiss merged commit 560b25e into cockroachdb:release-25.3 Jul 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches target-release-25.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants