Skip to content

clusterversion: move to 25.4 version #149494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

annrpom
Copy link
Contributor

@annrpom annrpom commented Jul 3, 2025

Checklist:

  • Add version key constant for new release (e.g. V24_2), equal to Latest. Note that we do NOT update the PreviousRelease constant. We can only update the PreviousRelease when an RC is published, which is needed for upgrade roachtests.
  • Add final version for the previous release (e.g. V24_1).
  • Add start version (e.g. V24_2Start with version 24.1-2) and add a new first upgrade for it (in upgrades/upgrades.go).
  • Update roachpb.successorSeries map and update TestReleaseSeriesSuccessor
  • Update pkg/build/version.txt to the new version (e.g. v24.2.0-alpha.00000000)
  • Update the scplan rules in pkg/sql/schemachanger/scplan/internal/rules:
    • copy the contents of current into a new release directory for the previous version (e.g. release_24_1)
    • change package name in all files (including BUILD.bazel), and update the version in current/helpers.go
    • update rulesForReleases in scplan/plan.go
    • rewrite the test outputs: ./dev test pkg/sql/schemachanger/scplan/internal/rules/... --rewrite
    • rewrite TestDeclarativeRules output: ./dev test pkg/cli -f DeclarativeRules --rewrite
  • Update releases file: bazel build //pkg/cmd/release:release _bazel/bin/pkg/cmd/release/release_/release update-releases-file Note that the forked release version will disappear from the releases file. This is what we want; if it is here, we will attempt to run upgrade tests against it.
  • Regenerate expected test data as needed (usually pkg/sql/catalog/systemschema_test and some logictests).

Epic: REL-2733
Release note: None

Copy link

blathers-crl bot commented Jul 3, 2025

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@annrpom annrpom force-pushed the bump-version-25.4 branch 5 times, most recently from 73c3245 to 210b435 Compare July 7, 2025 19:09
annrpom added 2 commits July 7, 2025 15:51
**Checklist**:

- [x] Add version key constant for new release (e.g. `V24_2`), equal to `Latest`.
  Note that we do NOT update the `PreviousRelease` constant. We can only update the
  `PreviousRelease` when an RC is published, which is needed for upgrade
  roachtests.
- [x] Add final version for the previous release (e.g. `V24_1`).
- [x] Add start version (e.g. `V24_2Start` with version `24.1-2`) and add a new
  first upgrade for it (in `upgrades/upgrades.go`).
- [x] Update `roachpb.successorSeries` map and update `TestReleaseSeriesSuccessor`
- [x] Update `pkg/build/version.txt` to the new version (e.g. `v24.2.0-alpha.00000000`)
- [x] Update releases file:
  ```
  bazel build //pkg/cmd/release:release
  _bazel/bin/pkg/cmd/release/release_/release update-releases-file
  ```
  Note that the forked release version will disappear from the releases file. This
  is what we want; if it is here, we will attempt to run upgrade tests against it.
- [x] Regenerate expected test data as needed (usually
  `pkg/sql/catalog/systemschema_test` and some logictests).

Epic: REL-2733
Release note: None
**Checklist**:

- [x] Update the `scplan` rules in `pkg/sql/schemachanger/scplan/internal/rules`:
  - copy the contents of `current` into a new release directory for the previous version
    (e.g. `release_24_1`)
  - change package name in all files (including `BUILD.bazel`), and update the
    version in `current/helpers.go`
  - update `rulesForReleases` in `scplan/plan.go`
  - rewrite the test outputs: `./dev test pkg/sql/schemachanger/scplan/internal/rules/... --rewrite`
  - rewrite `TestDeclarativeRules` output: `./dev test pkg/cli -f DeclarativeRules --rewrite`

Epic: REL-2733
Release note: None
@annrpom annrpom force-pushed the bump-version-25.4 branch from 210b435 to 18c5cb6 Compare July 7, 2025 19:51
@annrpom annrpom marked this pull request as ready for review July 7, 2025 20:32
@annrpom annrpom requested review from a team as code owners July 7, 2025 20:32
@annrpom annrpom requested review from celiala and rail July 7, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants