go.mod, storage: bump pebble + enable multilevel compactions by default with a cluster setting #149498
+22
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * [`20e2cbcd`](cockroachdb/pebble@20e2cbcd) db: support overriding value separation minimum-size by key span * [`50d7fd77`](cockroachdb/pebble@50d7fd77) pebble: add additional constraints to running multiLevel compactions * [`f810bcdf`](cockroachdb/pebble@f810bcdf) pebble: make MultiLevelCompactionHeuristic a function option Release note: none. Epic: none.
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
xinhaoz
changed the title
xinhaoz
force-pushed
the
xinhao/pebble-master-20e2cbcd70de
branch
from
f4ac95a to
a5095aa
Compare
Reenable multilevel compactions, with more constraints. ML compactions will run according to a write amp heuristic, along with the following rules: - At most 1 ML compaction is running at any time. - The db must have >= 2 maximum compaction slots. Closes: cockroachdb/pebble#4139
xinhaoz
force-pushed
the
xinhao/pebble-master-20e2cbcd70de
branch
from
a5095aa to
e8d6f70
Compare
rickystewart
approved these changes
Jul 7, 2025
sumeerbhola
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1: go.mod: bump Pebble to 20e2cbcd70de
Changes:
20e2cbcddb: support overriding value separation minimum-size by key span50d7fd77pebble: add additional constraints to running multiLevel compactionsf810bcdfpebble: make MultiLevelCompactionHeuristic a function optionRelease note: none.
Epic: none.
2: storage: enable multilevel compactions by default with a cluster setting
Reenable multilevel compactions, with more constraints. ML compactions will run
according to a write amp heuristic, along with the following rules:
Closes: cockroachdb/pebble#4139