release-25.3: roachtest: deflake splits/load/ycsb/e #149544
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
This test has a long history of flakes. The main reason is that at the first couple of minutes of the test, there many splits could happen because of the init phase of the workload increases the CPU and it has many inserts. However, for the remainder of the test, the workload is mostly scans, and that shouldn't cause many splits. This commit increases the maximumRanges allowed by 2. We ~recently increased it to the current number and saw almost now flakes, so increasing it by 2 should hopefully be enough. In the future, if we see many flakes of this nature. I think we should ignore the splits that happen in the first 2 minutes of the test, and focus on the fact that the splits in the remained of the test are minimal. Fixes: #149516 Release Note: None
blathers-crl
bot
added
blathers-backport
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
the
backport
|
This change is |
blathers-crl
bot
added
the
backport-test-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #149535 on behalf of @iskettaneh.
This test has a long history of flakes. The main reason is that at the first couple of minutes of the test, there many splits could happen because of the init phase of the workload increases the CPU and it has many inserts. However, for the remainder of the test, the workload is mostly scans, and that shouldn't cause many splits.
This commit increases the maximumRanges allowed by 2. We ~recently increased it to
the current number and saw almost now flakes, so increasing it by 2 should hopefully
be enough.
In the future, if we see many flakes of this nature. I think we should ignore the splits that happen in the first 2 minutes of the test, and focus on the fact that the splits in the remainder of the test are minimal.
Fixes: #149516
Release Note: None
Release justification: