Skip to content

release-25.3: logictest: fix user logictest for provisioning gating validation #149553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 5, 2025

Backport 1/1 commits from #149416 on behalf of @souravcrl.


The current logictest validates the version gating logic for provisioning but checks for skipif version instead of onlyif version config which was pointed out in the discussion
#149405 (comment) and needs to change. Additionally, we need to add a comment for version gating logic as both are failure scenarios owing to "cert-password" currently being a non support provisioning auth method as in the discussion #149405 (comment).

fixes #147599
Epic CRDB-21590

Release note: None


Release justification: needed to support user provisioning planned for 25.3

The current logictest validates the version gating logic for provisioning but
checks for skipif version instead of onlyif version config which was pointed out
in the discussion
#149405 (comment) and
needs to change. Additionally, we need to add a comment for version gating logic
as both are failure scenarios owing to "cert-password" currently being a non
support provisioning auth method as in the discussion
#149405 (comment).

fixes #147599
Epic CRDB-21590

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-25.3-149416 branch from e0f9c5e to d1ec373 Compare July 5, 2025 11:44
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 5, 2025
@blathers-crl blathers-crl bot requested review from rafiss and souravcrl July 5, 2025 11:44
@blathers-crl blathers-crl bot added O-robot Originated from a bot. blathers-backport This is a backport that Blathers created automatically. labels Jul 5, 2025
Copy link
Author

blathers-crl bot commented Jul 5, 2025

Thanks for opening a backport.

Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jul 5, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Jul 5, 2025
@souravcrl souravcrl requested a review from pritesh-lahoti July 7, 2025 06:39
@souravcrl souravcrl merged commit b8c4c6f into release-25.3 Jul 7, 2025
15 checks passed
@souravcrl souravcrl deleted the blathers/backport-release-25.3-149416 branch July 7, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-25.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants