Updates #43
Merged
Updates #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pointlessone
force-pushed
the
updates
branch
18 times, most recently
from
52a9ca9 to
14d8660
Compare
A migration to CircleCI 2.0 is needed because of the introduction of test image. The test image has to be based off of production image to actually test production code. Since production image name is generated we need to make it available in the test image dockerfile. For that we have to use the `ARG` directive. This feature is supported in Docker 17.06. CircleCI 1.0 runs Docker 1.8.2. CircleCI 2.0 with docker executor runs 17.03. That's why we have to use machine executor with a newer image.
codeclimate-hermes
requested review from
dblandin
and removed request for
codeclimate-hermes
pointlessone
requested review from
codeclimate-hermes
and removed request for
dblandin
codeclimate-hermes
requested review from
ale7714
and removed request for
codeclimate-hermes
ale7714
reviewed
Oct 31, 2017
| test: image | ||
| docker run --rm $(IMAGE_NAME) sh -c "cd /usr/src/app && vendor/bin/phpunit --bootstrap engine.php ./tests" | ||
| test: | ||
| @$(MAKE) test-image > /dev/null |
There was a problem hiding this comment.
is the step Prebuild image necessary, if you have make test-image here?
There was a problem hiding this comment.
It's not necessary but it makes the test step on CI less noisy.
ale7714
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A migration to CircleCI 2.0 is needed because of the introduction of test image. The test image has to be based off of production image to actually test production code. Since production image name is generated we need to make it available in the test image dockerfile. For that we have to use the
ARGdirective. This feature is supported in Docker 17.06. CircleCI 1.0 runs Docker 1.8.2. CircleCI 2.0 with docker executor runs 17.03. That's why we have to use machine executor with a newer image.