build: fix it for alpine #1835
build: fix it for alpine #1835
Conversation
| pull_request: | ||
| # The branches below must be a subset of the branches above | ||
| branches: [ main ] | ||
| branches: [main] | ||
| schedule: |
There was a problem hiding this comment.
TIL how to schedule action runs
There was a problem hiding this comment.
fyi, these are... fluffy. don't rely on crons in GHA for precise timing
| @@ -133,3 +133,40 @@ jobs: | |||
| version: v9.1.0 | |||
| verbose: true | |||
| token: ${{ secrets.CODECOV_TOKEN }} | |||
|
|
|||
| run-alpine: | |||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Detect shell |
There was a problem hiding this comment.
why is this necessary? Can't we just use sh for everything?
| - name: Action version | ||
| shell: bash | ||
| shell: ${{ env.CC_SHELL }} |
There was a problem hiding this comment.
W that all this stuff just works in the less featured shells
| @@ -1,4 +1,3 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
you can do a shebang for sh - would recommend as otherwise I believe it just uses the default shell, which could potentially be bad? Regardless would rather be explicit about the API necessary for the script to run
|
Oh I see your commits are called try something lol Ping me on slack when actually need a review. I was going based on GH notifications |
No description provided.