Skip to content

feat(ta-gql): handle receiving all branches filter #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joseph-sentry
Copy link
Contributor

add all branches special case for TA results branch filter in new TA
functionality

@joseph-sentry joseph-sentry requested a review from a team May 2, 2025 15:24
Copy link

seer-by-sentry bot commented May 2, 2025

✅ Sentry found no issues in your recent changes ✅

@codecov-notifications
Copy link

codecov-notifications bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/migrate_timeseries.py 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.13%. Comparing base (8c33711) to head (03d2aab).
Report is 70 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/migrate_timeseries.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files        1205     1205           
  Lines       45116    45122    +6     
  Branches     1448     1448           
=======================================
+ Hits        42468    42476    +8     
+ Misses       2343     2341    -2     
  Partials      305      305           
Flag Coverage Δ
apiunit 96.40% <100.00%> (+0.04%) ⬆️
workerintegration 61.69% <0.00%> (-0.02%) ⬇️
workerunit 90.92% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry force-pushed the joseph/all-branches branch from 639317e to b49b58a Compare May 2, 2025 15:31
Comment on lines +877 to +884
storage = get_appropriate_storage_service()
try:
storage.create_root_storage(settings.GCS_BUCKET_NAME)
except BucketAlreadyExistsError:
pass
storage.write_file(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use mock_storage for this? I believe when that is missing, this is targetting the minio running in docker?
Using the mock_storage would make things easier as you won’t have to create the bucket or clean up the file (which btw won’t run if the assertions fail, because there is no try/finally)

add all branches special case for TA results branch filter in new TA
functionality
@joseph-sentry joseph-sentry force-pushed the joseph/all-branches branch from b49b58a to 03d2aab Compare May 5, 2025 14:22
@joseph-sentry joseph-sentry enabled auto-merge May 27, 2025 14:52
@joseph-sentry joseph-sentry disabled auto-merge May 29, 2025 15:48
@joseph-sentry joseph-sentry enabled auto-merge May 29, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants