-
Notifications
You must be signed in to change notification settings - Fork 3
feat(ta-gql): handle receiving all branches filter #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 1205 1205
Lines 45116 45122 +6
Branches 1448 1448
=======================================
+ Hits 42468 42476 +8
+ Misses 2343 2341 -2
Partials 305 305
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
639317e
to
b49b58a
Compare
storage = get_appropriate_storage_service() | ||
try: | ||
storage.create_root_storage(settings.GCS_BUCKET_NAME) | ||
except BucketAlreadyExistsError: | ||
pass | ||
storage.write_file( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use mock_storage
for this? I believe when that is missing, this is targetting the minio running in docker?
Using the mock_storage
would make things easier as you won’t have to create the bucket or clean up the file (which btw won’t run if the assertions fail, because there is no try/finally)
add all branches special case for TA results branch filter in new TA functionality
b49b58a
to
03d2aab
Compare
add all branches special case for TA results branch filter in new TA
functionality