-
Notifications
You must be signed in to change notification settings - Fork 3
feat: enable new TA tasks on new repos #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Sentry detected 2 potential issues in your recent changesSuspicion of a potential technical issue in `apps/worker/tasks/upload.py:758~773` where the result of `commit.get_db_session()` is used directly without checking if it returned `None`, which could lead to an `AttributeError`.
Suspicion of a potential `AttributeError` at `apps/worker/tasks/upload.py:758`. The code calls `.query()` on the result of `get_db_session()` without checking if it returned `None`, which could happen if the commit object is detached or transient, leading to unexpected task termination.
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 1214 1214
Lines 45022 45030 +8
Branches 1435 1435
=======================================
+ Hits 42418 42426 +8
Misses 2303 2303
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Gonna wait to merge this until i confirm i fixed timescale |
22f8b07
to
55f3f2f
Compare
55f3f2f
to
9670404
Compare
9670404
to
fe76dae
Compare
Since we don't need to wait for any data to backfill to Timescale for new users we can just start using the new TA task impl.