Skip to content

build: unified Dockerfile #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: unified Dockerfile #186

wants to merge 1 commit into from

Conversation

matt-codecov
Copy link
Collaborator

@matt-codecov matt-codecov commented May 28, 2025

make worker, codecov-api, and shared use the same docker/Dockerfile to build their respective containers

they are still separate images with the same names as before. they use the WORKDIR and ENTRYPOINT build args to inject the appropriate values for each project. the images are essentially identical except for those, however - we could publish a single image and infra can change deploys to override the workdir and entrypoint to streamline

note: this new Dockerfile uses a non-root user. shouldn't affect anything but heads up

Stack info:
Stack 1

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (90251ff) to head (ef02fc6).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files        1214     1214           
  Lines       45022    45023    +1     
  Branches     1435     1435           
=======================================
+ Hits        42418    42419    +1     
  Misses       2303     2303           
  Partials      301      301           
Flag Coverage Δ
apiunit 96.48% <ø> (ø)
sharedintegration 39.74% <100.00%> (+<0.01%) ⬆️
sharedunit 88.15% <100.00%> (+<0.01%) ⬆️
workerintegration 61.61% <ø> (ø)
workerunit 90.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@matt-codecov matt-codecov force-pushed the branchless/pr186 branch 3 times, most recently from 9f08ec3 to 6e07cd5 Compare May 28, 2025 21:42
@matt-codecov matt-codecov requested review from a team May 28, 2025 22:10
@matt-codecov matt-codecov marked this pull request as ready for review May 28, 2025 22:10
### The "requirements image": `Dockerfile.requirements`

We have a single base image for all of our services which installs various
system dependencies (e.g. `apt-get install libpq-dev`) as well the Python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need libpq-dev? I thought we have switched to precompiled psycopg binaries that do not require building from source?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. i imagined psycopg's binary distribution was not a rebundling of libpq but rather a c-layer wrapper of their own, but i don't know

@matt-codecov matt-codecov force-pushed the branchless/pr186 branch 2 times, most recently from f51e575 to 19a4451 Compare June 4, 2025 19:14
Copy link

codspeed-hq bot commented Jun 4, 2025

CodSpeed Performance Report

Merging #186 will not alter performance

Comparing branchless/pr186 (ef02fc6) with main (6efc689)

Summary

✅ 9 untouched benchmarks

@codecov-test
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

seer-by-sentry bot commented Jun 11, 2025

✅ Sentry found no issues in your recent changes ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants