-
Notifications
You must be signed in to change notification settings - Fork 3
build: unified Dockerfile #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
119ab37
to
4060a31
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 1214 1214
Lines 45022 45023 +1
Branches 1435 1435
=======================================
+ Hits 42418 42419 +1
Misses 2303 2303
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
9f08ec3
to
6e07cd5
Compare
### The "requirements image": `Dockerfile.requirements` | ||
|
||
We have a single base image for all of our services which installs various | ||
system dependencies (e.g. `apt-get install libpq-dev`) as well the Python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need libpq-dev
? I thought we have switched to precompiled psycopg binaries that do not require building from source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question. i imagined psycopg's binary distribution was not a rebundling of libpq but rather a c-layer wrapper of their own, but i don't know
f51e575
to
19a4451
Compare
CodSpeed Performance ReportMerging #186 will not alter performanceComparing Summary
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
19a4451
to
141f3b1
Compare
141f3b1
to
ed8accc
Compare
✅ Sentry found no issues in your recent changes ✅ |
ed8accc
to
1e609d1
Compare
1e609d1
to
e97605b
Compare
e97605b
to
ef02fc6
Compare
make worker, codecov-api, and shared use the same
docker/Dockerfile
to build their respective containersthey are still separate images with the same names as before. they use the
WORKDIR
andENTRYPOINT
build args to inject the appropriate values for each project. the images are essentially identical except for those, however - we could publish a single image and infra can change deploys to override the workdir and entrypoint to streamlinenote: this new
Dockerfile
uses a non-root user. shouldn't affect anything but heads upStack info: