-
Notifications
You must be signed in to change notification settings - Fork 3
chore(api): remove test-only function from production helper file #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aeb21d4
to
0baa91a
Compare
4149d15
to
ffcc8cd
Compare
4060a31
to
b0b9f32
Compare
ffcc8cd
to
9c59722
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 1214 1215 +1
Lines 45022 45023 +1
Branches 1435 1435
=======================================
+ Hits 42416 42417 +1
Misses 2305 2305
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b0b9f32
to
9f08ec3
Compare
9c59722
to
1c4431d
Compare
9f08ec3
to
6e07cd5
Compare
1c4431d
to
9639759
Compare
6e07cd5
to
f51e575
Compare
9639759
to
454a57e
Compare
f51e575
to
19a4451
Compare
454a57e
to
5555563
Compare
5555563
to
9fb4f72
Compare
19a4451
to
141f3b1
Compare
9fb4f72
to
2b10c2b
Compare
141f3b1
to
ed8accc
Compare
2b10c2b
to
fc5d1b1
Compare
✅ Sentry found no issues in your recent changes ✅ |
1e609d1
to
e97605b
Compare
fc5d1b1
to
4498049
Compare
4498049
to
7dcce30
Compare
ef02fc6
to
7e76db6
Compare
7dcce30
to
cfc3072
Compare
cfc3072
to
78ca2a7
Compare
needed for #188
apps/codecov-api/billing/helpers.py
is imported in prod, but one of the things in it is a test-only helper that referenced test-only deps. if you start the service without dev dependencies installed, it blows up when importing that file.so, this PR moves the test-only stuff to a different file that is not included by prod code
Stack info: