Skip to content

chore(api): remove test-only function from production helper file #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

matt-codecov
Copy link
Collaborator

@matt-codecov matt-codecov commented May 28, 2025

needed for #188

apps/codecov-api/billing/helpers.py is imported in prod, but one of the things in it is a test-only helper that referenced test-only deps. if you start the service without dev dependencies installed, it blows up when importing that file.

so, this PR moves the test-only stuff to a different file that is not included by prod code

Stack info:
Stack 1

@codecov-notifications
Copy link

codecov-notifications bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (d3d8f72) to head (78ca2a7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files        1214     1215    +1     
  Lines       45022    45023    +1     
  Branches     1435     1435           
=======================================
+ Hits        42416    42417    +1     
  Misses       2305     2305           
  Partials      301      301           
Flag Coverage Δ
apiunit 96.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✅ Sentry found no issues in your recent changes ✅

@matt-codecov matt-codecov force-pushed the branchless/pr186 branch 2 times, most recently from 1e609d1 to e97605b Compare June 16, 2025 23:30
@matt-codecov matt-codecov changed the base branch from branchless/pr186 to main June 16, 2025 23:32
@matt-codecov matt-codecov changed the base branch from main to branchless/pr186 June 16, 2025 23:34
Base automatically changed from branchless/pr186 to main June 18, 2025 19:18
@matt-codecov matt-codecov added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 9d48d09 Jun 18, 2025
39 checks passed
@matt-codecov matt-codecov deleted the branchless/pr187 branch June 18, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants