-
Notifications
You must be signed in to change notification settings - Fork 3
build: remove dev deps from prod image, add separate test-reqs and test-app images #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branchless/pr190
Are you sure you want to change the base?
Conversation
4149d15
to
ffcc8cd
Compare
8784b3a
to
5934b81
Compare
ffcc8cd
to
9c59722
Compare
5934b81
to
21ee344
Compare
9c59722
to
1c4431d
Compare
21ee344
to
af6e718
Compare
1c4431d
to
9639759
Compare
af6e718
to
94d39c6
Compare
9b12375
to
f9b86d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## branchless/pr190 #188 +/- ##
=================================================
Coverage 94.21% 94.21%
=================================================
Files 1215 1215
Lines 45024 45024
Branches 1435 1435
=================================================
Hits 42420 42420
Misses 2303 2303
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #188 will not alter performanceComparing Summary
|
30500e4
to
ec7ae18
Compare
f9b86d4
to
c4e8db7
Compare
ec7ae18
to
ae201f3
Compare
c4e8db7
to
163bbf6
Compare
ae201f3
to
e8e82aa
Compare
163bbf6
to
52f8bea
Compare
e8e82aa
to
009423d
Compare
52f8bea
to
2fe900e
Compare
009423d
to
3316f91
Compare
2fe900e
to
4011df8
Compare
Sentry detected 2 potential issues in your recent changesSuspicion of a critical build issue: The PR adds references to missing Docker build files (`Makefile.docker`, `Dockerfile.requirements`, etc.) and targets, causing the build process to fail immediately with "No such file or directory" or "No rule to make target" errors, preventing image creation.
Suspicion of a technical issue in `docker/Makefile.docker:10`. A new reference to a non-existent file `docker/Dockerfile.requirements` is added, which could cause build processes to fail when attempting to calculate its hash.
Did you find this useful? React with a 👍 or 👎 |
3316f91
to
0f86fa5
Compare
4011df8
to
f07f2de
Compare
0f86fa5
to
cddf945
Compare
f07f2de
to
0db3372
Compare
as title
this should clean up our production image as well as save some CI time. as-is, every CI run for worker, api, and shared all must run
apt-get install ...
andpip install ...
to install the same junk inside the container. this PR caches that junk so all that must be done most of the time is copying the repo into the imagefurther changes are possible. all three test images are essentially identical; we could just build/publish a generic test image and override the workdir and entrypoint in docker-compose. i may try to do basically that for our production images.
Stack info: