ci: add build-app.yml back to push-stage.yml to ensure image exists #216
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-codecov
force-pushed
the
matt/staging-ci
branch
from
5648d57 to
9b12768
Compare
ajay-sentry
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let's say you push current
maintostaging. if the latest commit onmaindoes not touch worker, or does not touch API, those parts of push-stage.yml will fail due to not having an image and staging won't actually be updated.this PR adds the
_build-app.ymlstep back topush-stage.yml. most of the time it should get to use an image from GHA's cache or pull a prebuilt image from our container registry and early-exit.it also adds an early-exit to
_build-app.ymlif we have a cache hit on the app's image