Skip to content

chore: Test overwatch staging #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

suejung-sentry
Copy link
Contributor

DO NOT MERGE
this is a test

Copy link

overwatch-beta bot commented Jun 11, 2025

Sentry detected 1 potential issue in your recent changes

Suspect the CI workflow may fail unexpectedly if network connectivity issues prevent the `curl` command from downloading the Overwatch CLI. The lack of error handling means a non-zero exit code from `curl` due to network problems will halt the workflow before subsequent steps can run.
  • Description: The workflow downloads the Overwatch CLI using curl without the -f flag or explicit error handling. GitHub Actions defaults to stopping a job if any step returns a non-zero exit code. While curl might return 0 for HTTP errors without -f, it will return non-zero codes (e.g., 6 for DNS resolution failure, 7 for connection failure, 28 for timeout) for network connectivity issues like DNS failures, connection refusals, or timeouts. Since the subsequent step attempts to execute the downloaded binary, a failure in the download step due to network issues will cause the execution step to fail because the binary does not exist. This dependency means network problems during download will halt the entire workflow unexpectedly. For example, if DNS resolution for overwatch.codecov.dev fails (curl exit code 6), the 'Install Overwatch CLI' step will fail, preventing the 'Run Overwatch CLI' step from executing, leading to a workflow failure.
  • Code location: .github/workflows/upload-overwatch.yml:30
  • Suggested fix: Add error handling to the curl step to prevent workflow failure on network issues. Consider using continue-on-error: true for this step or adding explicit checks for the curl exit code before proceeding.

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant