-
Notifications
You must be signed in to change notification settings - Fork 3
ci: use gh cli in ci-router to dispatch worker/api/shared jobs #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Sentry detected 1 potential issue in your recent changesSuspicion of a critical bug: The new `gh workflow run` commands lack error handling, causing the CI pipeline to fail unexpectedly on transient issues like API errors, potentially blocking deployments.
Did you find this useful? React with a 👍 or 👎 |
2072345
to
9844438
Compare
9844438
to
52adf08
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 1214 1214
Lines 45036 45036
Branches 1434 1434
=======================================
Hits 42424 42424
Misses 2309 2309
Partials 303 303
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #234 will not alter performanceComparing Summary
|
two things:
ci-router.yml
,worker-ci.yml
,api-ci.yml
, andshared-ci.yml
. i think by using thegh
cli to invoke worker/api/shared CI, we sidestep that limit and api/shared/worker each get their own limit of 20 to work with.push-stage.yml
is also moved back insideworker-ci.yml
andapi-ci.yml
. any push to staging should now result in a deploy of that commit for both worker and api.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.