-
Notifications
You must be signed in to change notification settings - Fork 3
fix(shared): Use the only available settings file #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sentry detected 2 potential issues in your recent changesSuspicion: The shared app's manage.py hardcodes test database settings, which might cause `OperationalError` when attempting database connections in production environments.
Suspicion: Hardcoding `settings_test.py` in `libs/shared/shared/django_apps/manage.py` might cause database connection issues in non-test environments. The test settings contain hardcoded test hostnames that could trigger `OperationalError` if used outside the test setup.
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 94.21% 94.23% +0.02%
==========================================
Files 1214 1215 +1
Lines 45022 45023 +1
Branches 1435 1435
==========================================
+ Hits 42416 42427 +11
+ Misses 2305 2295 -10
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #244 will not alter performanceComparing Summary
|
54df06a
to
e3c9f01
Compare
Running `manage.py` commands currently fails because the CLI is looking for `settings_prod.py` which does not exist for `shared`.
90739c1
to
c63aeb5
Compare
c63aeb5
to
236c182
Compare
Running
manage.py
commands currently fails because Django is looking forsettings_prod.py
which does not exist forshared
.