Skip to content

run shell path async to avoid blocking config load #6446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented Jul 4, 2025

Description

getEnvPathFromUserShell was causing unresponsive extension host when loading MCP servers (stdio). Making it async solves this

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Summary by cubic

Loading the user shell PATH is now done asynchronously to prevent blocking the extension host during MCP server startup.

  • Refactors
    • Replaced sync shell PATH loading with async calls in MCP connection setup.
    • Updated related utility to use async execution.

@sestinj sestinj requested a review from a team as a code owner July 4, 2025 06:08
@sestinj sestinj requested review from tomasz-stefaniak and removed request for a team July 4, 2025 06:08
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 3668ba6
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/68676fc64878f50008b1b0a1

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 4, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 2 files and found no issues. Review PR in cubic.dev.

Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 7, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants