[drizzle-kit]: Fix push deleting then re-adding unchanged unique constraints #4565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Please merge. |
|
Add tests. |
|
The new drizzle-kit should land any moment now folks, let's hope this is fixed in there 🥲 |
|
when will this be added? |
|
🙏 🚀 |
|
Would love to see this and #3092 get merged to clear up two issues around unique constraints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix drizzle-kit push deleting then re-adding unchanged unique constraints.
During push, the TS schema and database might have different column orders in unique keys, resulting in
drizzle-kit pushdeleting then readding the same unique constraint (and generating a warning that needs to be manually responded to too). This PR addssort()to allsquashUnique()methods.This fixes #2888. I know there are a couple of other fixes out there (as part of #3999 and part of #4043), but I believe this to be a much more concise solution.
See my original discussion for a deep-dive of why this is happening #2888 (comment)