fix: use undefined check to avoid crash when set[colName]
is null
#4709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is related to the
buildUpdateSet
method in each Dialect class.This filters columns so that only those defined in
set
or with anonUpdateFn
are used:drizzle-orm/drizzle-orm/src/pg-core/dialect.ts
Lines 155 to 157 in ac1dcd9
While this erroneous check uses
??
which accidentally "skips"null
when it shouldn't, resulting in a crash if the column has noonUpdateFn
(or incorrect behavior if it does have anonUpdateFn
):drizzle-orm/drizzle-orm/src/pg-core/dialect.ts
Line 163 in ac1dcd9