Do not automatically start tracing transactions in TaskManager #130607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes TaskManager to only create new tracing spans if a trace parent (and hence a tracing transaction) already exists. Tracing transactions are automatically started in the RestController for external requests. To trace detached, internal transport actions, a transaction has to be explicitly started using Tracer.startTrace. This helps to prevent everlasting tracing transaction for internal self-rescheduling work that is using transport actions. Such transactions have caused memory issues with the APM java agent in the past. Relates to ES-10969
mosche
requested review from
DaveCTurner and
a team
and removed request for
a team
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
Team:Core/Infra
prdoyle
approved these changes
Jul 7, 2025
server/src/main/java/org/elasticsearch/common/util/concurrent/ThreadContext.java
Outdated
Show resolved
Hide resolved
DaveCTurner
reviewed
Jul 8, 2025
server/src/main/java/org/elasticsearch/common/util/concurrent/ThreadContext.java
Outdated
Show resolved
Hide resolved
|
@DaveCTurner this PR contains only the remaining key changes and should be ready for another review |
DaveCTurner
approved these changes
Jul 10, 2025
mosche
added
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes TaskManager to only create new tracing spans if a trace parent (and hence a tracing transaction) already exists.
Tracing transactions are automatically started in the RestController for external requests. To trace detached, internal transport actions, a transaction has to be explicitly started using Tracer.startTrace.
This helps to prevent everlasting tracing transaction for internal self-rescheduling work that is using transport actions. Such transactions have caused memory issues with the APM java agent in the past.
Relates to ES-10969