Set the pattern to the http.Request #5697
Open
+120
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -532,6 +532,7 @@ type handler struct { | |||
| } | |||
|
|
|||
| func (s *ServeMux) handleHandler(h handler, w http.ResponseWriter, r *http.Request, pathParams map[string]string) { | |||
| r.Pattern = h.pat.GetPathPattern() | |||
There was a problem hiding this comment.
Isn't this going to overwrite the Pattern set by net/http? What about users who use r.Pattern today?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
The PR is related to Issue #3700
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
Now
http.Requesthas thePatternfield set.httpServeMuxdoes this and other libraries make use of this value. Nowruntime.ServeMuxalso populates this field.Other comments
A bit more context in the comment