Add actions to provider interface #37006
Conversation
DanielMSchmidt
added
the
no-changelog-needed
|
Will the version of the protocol version stay at 6.10? |
DanielMSchmidt
force-pushed
the
TF-25930
branch
3 times, most recently
from
f3d5ac9 to
0b0cfdd
Compare
| return resp | ||
| } | ||
|
|
||
| func (p *GRPCProvider) InvokeAction(r providers.InvokeActionRequest) (resp providers.InvokeActionResponse) { |
There was a problem hiding this comment.
This one is just a genuine question I'm curious about, not a review:
How will the action event stream get cancelled from the terraform side (ie user ctrl-c or a timeout)? Does that get handled by the provider when tf calls Stop()?
There was a problem hiding this comment.
I would have assumed it stops when we call Stop and the provider winds down, but it's sth we should test for sure
There was a problem hiding this comment.
The framework shouldbe connecting it's global context to interrupt the call when Stop is called, but Terraform can't control that.
For managed resources we don't want to directly interrupt them from the CLI because they may have state to save, and so we wait for the provider to do the cancelation and return whatever info it can. Since list resources can't have side effects however, we might want to someday pipe through our cancellation context here, but I don't think that's required for now, and would require some new plumbing.
This PR adds actions to the provider interface and implements the basic functionality against the provider protocol.
Fixes #
Target Release
1.13.x
CHANGELOG entry