Skip to content

Update README (spelling, phrasing, formatting) #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2016

Conversation

Zearin
Copy link
Contributor

@Zearin Zearin commented Oct 4, 2016

No description provided.

Copy link
Owner

@julienXX julienXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnaks a lot! I left some comments.


-------------------------------------------------------------------------------

`-reply` **[10.9+ only]**

The notification will be displayed as a reply type alert.
Displayed the notification as a reply type alert.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display instead of Displayed


-------------------------------------------------------------------------------

`-actions VALUE1,VALUE2,"VALUE 3"` **[10.9+ only]**

The notification actions avalaible.
Use notification actions avalaible.
Copy link
Owner

@julienXX julienXX Oct 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of actions available for the notification maybe?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

available is spelt incorrectly ...

@@ -1,27 +1,27 @@
# terminal-notifier

terminal-notifier is a command-line tool to send Mac OS X User Notifications,
which are available in Mac OS X 10.8 and higher.
terminal-notifier is a command-line tool to send OS X User Notifications,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's time to change for macOS which is the current name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sounds good to me. (I was on the fence about that one when I was editing anyway. )

@@ -212,45 +221,43 @@ Examples are:

`-sender ID`

Specifying this will make it appear as if the notification was send by that
application instead, including using its icon.
Fakes the sender application of the notification. This uses the specified
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many spaces before This I think.

@julienXX julienXX merged commit e16e4c2 into julienXX:master Oct 4, 2016
@julienXX
Copy link
Owner

julienXX commented Oct 4, 2016

Thanks @Zearin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants