feat: completely factorize SubtleCrypto.generateKey() #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Bashamega
suggested changes
Jun 24, 2025
hkleungai
force-pushed
the
crypto-factorize-subtle.generateKey
branch
from
53beb15 to
0dc3d22
Compare
Renegade334
reviewed
Jul 2, 2025
Comment on lines
+1797
to
+1808
| "typeParameters": [ | ||
| { | ||
| "name": "T", | ||
| "extends": "{ name: string }" | ||
| } | ||
| ], | ||
| "param": [ | ||
| { | ||
| "name": "algorithm", | ||
| "overrideType": "string | T" | ||
| } | ||
| ], |
There was a problem hiding this comment.
I believe this generic is needed, or else the fallback signature will fail to capture poosibly-work algorithm object with extra attibutes other than name.
There was a problem hiding this comment.
No-one's raised any issues with AlgorithmIdentifier; this seems an arbitrary modification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR in favor of this comment from @Renegade334 in my another PR in DT repo.
Since https://nodejs.org/api/webcrypto.html#cryptokeyusages lists the usages in its own table, and it is closely aligned to the MDN reference in https://developer.mozilla.org/docs/Web/API/SubtleCrypto/generateKey, I believe it is possible to raise such change to
@types/webas well.Potentially we can do this to other methods in the key-usages table, but let's see how reviewers think about this change, then we may perform the refactoring incrementally in subsequent PRs.
Fallback signature is also updated, in favor of matching richer shape of possible
Algorithmobject.