-
Notifications
You must be signed in to change notification settings - Fork 444
Switch from JSON to KDL format #2056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Introduced new types in "addedTypes.kdl", including mixins, enums, and interfaces relevant to web APIs. - Removed deprecated types and interfaces from "removedTypes.kdl", streamlining the codebase and ensuring compatibility with current standards.
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Err, I was saying that I'd like to add a new topic-separated files in KDL, not converting existing monolithic file to KDL. |
inputfiles/addedTypes.kdl
Outdated
@@ -0,0 +1,1650 @@ | |||
mixins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this formatting a mistake? This is pretty unreadable, way worse than described in the linked issue with the braces and so on
I understand @saschanaz |
Sounds good, but let's do it one by one in each PR so that the PR can be reviewed and merged separately! |
(I think we don't need to keep quirks like |
Hello @saschanaz |
#2053