Skip to content

Switch from JSON to KDL format #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Bashamega
Copy link
Contributor

Bashamega and others added 4 commits June 21, 2025 09:57
- Introduced new types in "addedTypes.kdl", including mixins, enums, and interfaces relevant to web APIs.
- Removed deprecated types and interfaces from "removedTypes.kdl", streamlining the codebase and ensuring compatibility with current standards.
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Contributor

Err, I was saying that I'd like to add a new topic-separated files in KDL, not converting existing monolithic file to KDL.

@@ -0,0 +1,1650 @@
mixins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this formatting a mistake? This is pretty unreadable, way worse than described in the linked issue with the braces and so on

@Bashamega
Copy link
Contributor Author

I understand @saschanaz
I am just converting the data for now, and trying to see if it works, when It works I will split them into sub files

@saschanaz
Copy link
Contributor

Sounds good, but let's do it one by one in each PR so that the PR can be reviewed and merged separately!

@saschanaz
Copy link
Contributor

saschanaz commented Jul 1, 2025

(I think we don't need to keep quirks like methods.method in KDL, we can skip that in KDL and convert to the existing JSON format (we'll need such conversion as KDL parse result itself will never be compatible as-is.)

@Bashamega
Copy link
Contributor Author

Hello @saschanaz
Currently, I am working on the read function.
And I found an issue with KDL that I can't find a fix for.
Some arrays only have one item, so KDL doesn't treat it as an array.
How can I make it an array?
I can only come up with one solution, which is when I want an array with one item and another item called, for example, KDLARRAY, and we will drop it when converting.
If you have a better solution, please tell me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants