Skip to content

Commit 7c1095d

Browse files
committed
Green light for non-corruption option .
1 parent 30638de commit 7c1095d

File tree

2 files changed

+6
-33
lines changed

2 files changed

+6
-33
lines changed

toolkit/tools/pkg/imagecustomizerlib/customizeverity.go

Lines changed: 6 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -327,9 +327,13 @@ func parseSystemdVerityOptions(options string) (imagecustomizerapi.CorruptionOpt
327327
case "restart-on-corruption":
328328
corruptionOption = imagecustomizerapi.CorruptionOptionRestart
329329

330-
default:
331-
return "", fmt.Errorf("unknown verity option (%s)", option)
330+
// ToDo: Green light to LG for this non-corruption option `root-hash-signature=`
331+
/*
332+
default:
333+
return "", fmt.Errorf("unknown verity option (%s)", option)
334+
*/
332335
}
336+
333337
}
334338

335339
return corruptionOption, nil
@@ -440,30 +444,3 @@ func findIdentifiedPartition(partitions []diskutils.PartitionInfo, ref imagecust
440444
}
441445
return partition, nil
442446
}
443-
444-
func ParseSystemdVerityOptions(options string) (imagecustomizerapi.CorruptionOption, error) {
445-
corruptionOption := imagecustomizerapi.CorruptionOptionIoError
446-
447-
optionValues := strings.Split(options, ",")
448-
for _, option := range optionValues {
449-
switch option {
450-
case "":
451-
// Ignore empty string.
452-
453-
case "ignore-corruption":
454-
corruptionOption = imagecustomizerapi.CorruptionOptionIgnore
455-
456-
case "panic-on-corruption":
457-
corruptionOption = imagecustomizerapi.CorruptionOptionPanic
458-
459-
case "restart-on-corruption":
460-
corruptionOption = imagecustomizerapi.CorruptionOptionRestart
461-
462-
default:
463-
// ToDo: Ignore unknown options like "root-hash-signature=/boot/root.hash.sig"
464-
logger.Log.Debugf("Ignoring unknown verity option: %s", option)
465-
}
466-
}
467-
468-
return corruptionOption, nil
469-
}

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -447,11 +447,7 @@ func findVerityPartitionsFromCmdline(partitions []diskutils.PartitionInfo, cmdli
447447
return diskutils.PartitionInfo{}, 0, verityDeviceMetadata{}, err
448448
}
449449

450-
<<<<<<< HEAD
451450
corruptionOption, err := parseSystemdVerityOptions(options)
452-
=======
453-
corruptionOption, err := ParseSystemdVerityOptions(options)
454-
>>>>>>> 10e6d5509 (COSI output image type support.)
455451
if err != nil {
456452
err = fmt.Errorf("failed parse verity options (%s) kernel argument:\n%w", optionsArgName, err)
457453
return diskutils.PartitionInfo{}, 0, verityDeviceMetadata{}, err

0 commit comments

Comments
 (0)