Image Customizer: clean the /boot folder selectively if keepKdumpBootFiles is specified #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmileka
force-pushed
the
user/gmileka/clean-boot
branch
from
2cc3608 to
641a0e6
Compare
gmileka
changed the title
gmileka
force-pushed
the
user/gmileka/clean-boot
branch
from
7151c1b to
8b3c5ff
Compare
cwize1
requested changes
Jun 27, 2025
| @@ -32,6 +32,23 @@ pxe: | |||
|
|
|||
| See also the [PXE Support](../../concepts/pxe.md) page. | |||
|
|
|||
| ## keepKdumpBootFiles [bool] | |||
There was a problem hiding this comment.
Use of this new API should sit behind a preview feature flag.
There was a problem hiding this comment.
! yes, I missed that
| @@ -25,13 +26,16 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| bootDirPermissions = 0700 | |||
| // without having to do an extra iteration. | ||
| sort.Strings(bootFolderFilePaths) | ||
|
|
||
| savedFilesDir, err := os.MkdirTemp("", "files-to-save-*") |
There was a problem hiding this comment.
Use the build directory for storing temporary files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean the /boot folder selectively if keepKdumpBootFiles is specified.
If set to true, the Image Customizer tool will not delete any kdump files found under the boot folder on the full OS image. The kdump files include:
initramfs-<kernel-version>kdump.img.vmlinuz-<kernel-version>- where its version matches that of theinitramfs-<kernel-version>kdump.img.The default is
false.Note that by default, the Image Customizer tool removes the
/bootfolder from the full OS image. This is because all of its contents have already been copied unto the root of the PXE artifacts folder.