Skip to content

Inconsistent ConversationParameters interface #4859

Open
@Wadu436

Description

@Wadu436

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Versions

  • What package version of the SDK are you using.
    botframework-schema@4.23.1

  • What nodejs version are you using
    N/A but Node 22

  • What browser version are you using
    N/A but Chrome

  • What os are you using
    N/A but MacOS 15.3

Describe the bug

There's an inconsistency between the docstring and the actual type for the activity field in the ConversationParameters interface. The docstring claims it is optional, but according to the type it is required.

To Reproduce

Steps to reproduce the behavior:

  1. Go to index.ts:872-876 file in the botframework-schema
  2. Look at the docstring for the activity field
  3. Look at the type for the activity field

Expected behavior

For the docstring and the interface to be consistent.

Metadata

Metadata

Assignees

Labels

bugIndicates an unexpected problem or an unintended behavior.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions