-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(docker): adding native GHCR container #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ke the variable hardcoded
…eally like to hardcode it but for testing purposes i'm gonna try
@microsoft-github-policy-service agree |
Forgot to say, there's a need to create a project variable called |
This looks very promising. Thank you. I need to check some procedural stuff on my end before I can merge this (re: hosting images rather than just Dockerfiles). Let me spend a day or two on this, and I'll get back to you. |
Hey @afourney,
However, i would love to talk about it with @seuros. From what i see, here's a table difference :
Additionally, @seuros added a From what i see, i believe we should implement the following :
For the Qemu action, i don't really know until i've talked with @seuros. |
This way, we'll have access to `ghcr.io/microsoft/markitdown:v1.0.0`, `ghcr.io/microsoft/markitdown:v2.0.0`, ... Instead of just `ghcr.io/microsoft/markitdown:main`
…ld-push-action` I don't see why v5 should be used instead of v6 ? Also, the [most recent `docker/build-push-action`](https://github.com/docker/build-push-action/blob/88844b95d8cbbb41035fa9c94e5967a33b92db78/README.md?plain=1#L53-L81)'s README tell us that version compatibility with the other actions is not an issue
Originally, if the user want to use Docker on this project, this are the steps he was gonna do :
docker build -t markitdown:latest .
docker run --rm -i markitdown:latest < ~/your-file.pdf > output.md
With this PR, i am hopping to simplify this procedure so that testing (and trying this repo out, for example to check if it correspond to our need) can be simplified to :
docker run --rm -i ghcr.io/microsoft/markitdown:latest < ~/your-file.pdf > output.md