fix: Make magika an optional dependency #1296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem The `magika` package was a hard dependency, causing import failures if not installed, even when basic functionality would work with Python's built-in `mimetypes`. ## Changes - Made `magika` import optional with graceful fallback - Updated [MarkItDown](cci:2://file:///d:/Github/markitdown/packages/markitdown/src/markitdown/_markitdown.py:95:0-784:26) to handle missing `magika` gracefully - Maintained all existing functionality when `magika` is available - Falls back to standard `mimetypes` when `magika` is not available ## Impact - CLI and library now work without `magika` installed - Better out-of-the-box experience for users - More robust error handling for file-type detection - No breaking changes to existing functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
magikapackage was a hard dependency, causing import failures if not installed, even when basic functionality would work with Python's built-inmimetypes.Changes
magikaimport optional with graceful fallbackmagikagracefullymagikais availablemimetypeswhenmagikais not availableImpact
magikainstalled