Skip to content

feat(ipx): use alternate URL style with format as file extension #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sgarner
Copy link

@sgarner sgarner commented Apr 4, 2025

πŸ”— Linked issue

Resolves #933, #584, #442

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Implements (and depends on) the alternate URL style for IPX proposed in unjs/ipx#259

This improves prerendering of images so that the target format is respected in the generated filename, fixing issues with static hosting. For full rationale please see the description in unjs/ipx#259

The original URL style will still be used when the requested format is auto (which is not applicable for prerendering anyway), or when no modifiers are given. Otherwise the new URL style will be used.

I'm not sure whether this needs to be classed as a breaking change. It will cause different URLs to be produced with ipx and ipxStatic providers, but that shouldn't break anything unless users are somehow relying on the old URL style.

@sgarner sgarner requested a review from danielroe as a code owner April 4, 2025 05:01
@sgarner sgarner marked this pull request as draft April 4, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doesn't generate other formats on "nuxt generate"
1 participant