Skip to content

fix(ui): improve collection description layout and spacing #12958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danicaleroo
Copy link
Contributor

What / Why

Collection descriptions had poor visual separation and spacing issues:

  • In list view: description was too close to the collection heading
  • In edit view: description appeared mixed with form fields, making it look like a regular field instead of a description section

This made descriptions less readable and visually confusing.

Changes introduced

  • packages/ui/src/elements/DocumentFields/index.tsx
    • Moved description header outside of Gutter component to create proper visual separation
  • packages/ui/src/elements/DocumentFields/index.scss
    • Added &__header styles with padding and borders to create a distinct section
    • Added responsive padding adjustments for mid-break screens
  • packages/ui/src/elements/ListHeader/index.scss
    • Added gap to .list-header to improve spacing between title and description
    • Added responsive gap adjustment for smaller screens

Behavior after the fix

  • List view: Collection descriptions now have proper spacing from the heading
  • Edit view: Descriptions appear in a visually distinct header section, separated from form fields
  • Responsive: Appropriate spacing adjustments on smaller screens

How to test manually

  1. Run pnpm dev admin to see admin test collections with descriptions
  2. OR run pnpm dev and add a collection description inside test/_community/collections/Posts/index.ts
  3. List view: Observe improved spacing between title and description
  4. Edit view: Notice description appears in a bordered header section, separate from form fields
  5. Test on different screen sizes to verify responsive behavior

Screenshots

List View - Before/After

List view - pnpm dev admin
List view - pnpm dev

Edit View - Before/After

Edit view - pnpm dev admin
Edit view - pnpm dev

Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including the screenshots making this review easy.

@danicaleroo
Copy link
Contributor Author

My pleasure!

@Patrickroelofs
Copy link
Contributor

I wanted to open a bug report about the description on Global collections, I find it being in a very strange position, did that possibly improve in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants