fix(ui): increase timeout for opening list drawer in RelationshipInput #13031
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanJablo
requested review from
jacobsfletch,
AlessioGr and
JarrodMFlesch
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #12529, the setTimeout was defined through trial and error as it wasn't possible to reproduce the bug with the devtools open and therefore with the CPU throttled. One user reported still experiencing the bug.
I'm increasing the timeout to 100ms, which seems acceptable enough to keep postponing a better fix, considering the bug isn't that critical.
If we find it keeps happening, we'll probably need to investigate the root cause.