fix: bun undici polyfill issue, only initialize safeDispatcher if skipSafeFetch is false #13032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… false hi, currently we are initializing safeDispatcher outside of the safeFetch function, which is causing edge case issue with bun and undici polyfill like this https://github.com/payloadcms/payload/blob/30fc7e3012dae81b3f727b35ff6917e75f271df1/packages/payload/src/uploads/safeFetch.ts#L52 if we move this to the function safeFetch , we can get rid of edge case like these , if user set `skipSafeFetch: true`. i have implemented this like that in this PR, till bun fixes undici polyfill issue this is a temporary fix. related issues payload payloadcms#12622 (comment) payloadcms#12622 (comment) related issues Bun oven-sh/bun#17799 oven-sh/bun#20022
geminigeek
changed the title
Merged
geminigeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi,
currently we are initializing safeDispatcher outside of the safeFetch function, which is causing edge case issue with bun and undici polyfill
like this
payload/packages/payload/src/uploads/safeFetch.ts
Line 52 in 30fc7e3
if we move this to the function safeFetch , we can get rid of edge case (see below) , if user set
skipSafeFetch: true.i have implemented this like that in this PR, till bun fixes undici polyfill issue this is a temporary fix.
related issues payload
#12622 (comment) #12622 (comment)
related issues Bun
oven-sh/bun#17799
oven-sh/bun#20022